-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graph: Add HTTP tracing option for MS Graph requests #3269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
added
enhancement
New feature or request
dependencies
Pull requests that update a dependency file
loki
labels
Nov 8, 2023
mbarnes
force-pushed
the
aro-msgraph-trace
branch
from
November 8, 2023 03:23
f147556
to
338ef2f
Compare
mbarnes
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan,
Shivkumar13,
yjst2012,
anshulvermapatel and
hlipsig
as code owners
November 8, 2023 03:28
Debug feature enabled by ARO_MSGRAPH_TRACE environment variable.
mbarnes
force-pushed
the
aro-msgraph-trace
branch
from
November 8, 2023 15:45
338ef2f
to
e38454a
Compare
/azp run e2e |
Azure Pipelines successfully started running 1 pipeline(s). |
SudoBrendan
previously approved these changes
Nov 8, 2023
bennerv
previously approved these changes
Nov 8, 2023
mbarnes
force-pushed
the
aro-msgraph-trace
branch
from
November 8, 2023 17:53
39e925d
to
06b3633
Compare
s-amann
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧔♂️
bennerv
approved these changes
Nov 8, 2023
cadenmarchese
approved these changes
Nov 8, 2023
This was referenced Nov 8, 2023
ventifus
pushed a commit
to ventifus/ARO-RP
that referenced
this pull request
Feb 7, 2024
* graph: Add HTTP tracing option for MS Graph requests Debug feature enabled by ARO_MSGRAPH_TRACE environment variable. * graph: Temporarily disable gzip compression in requests --------- Co-authored-by: Matthew Barnes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I recently reconstructed how I originally enabled HTTP tracing for MS Graph requests when porting the RP from Azure Active Directory Graph last year. I'm offering this up as a permanent debugging feature, enabled by defining an environment variable named
ARO_MSGRAPH_TRACE
. It might come in handy again in the future.